Bug 16249 – std.signals: disconnect() is unsafe during emit()

Hello, conisder the following code: ============================ module dtest; import std.signals; struct SIGLine { myLINE line; int value; } class myLINE { mixin Signal!SIGLine; void value(int v) { if (v >= 0) emit(SIGLine(this, v)); else emit(SIGLine(new myLINE, v)); } } class Dot { int value; myLINE line_; void line(myLINE line_x) { if (line_ is line_x) return; if (line_ !is null) { line_.disconnect(&watch); } line_ = line_x; line_.connect(&watch); } void watch(SIGLine sigline) { line = sigline.line; value = sigline.value; } } @system unittest { auto dot1 = new Dot; auto dot2 = new Dot; auto line = new myLINE; dot1.line = line; dot2.line = line; line.value = 11; assert(dot1.value == 11); assert(dot2.value == 11); line.value = -22; assert(dot1.value == -22); assert(dot2.value == -22); // ERROR } ============================ The error is because slots_idx is changed during the loop in emit().

Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/92eb63547953af2e6514a0fa6c9e109f70643b1b fix issue 16249 - std.signals: disconnect() is unsafe during emit() https://github.com/dlang/phobos/commit/910681ccc97df490871075c6dee6d8ae5db2d298 Merge pull request #4574 from nmtigor/issue_16249 fix issue 16249 - std.signals: disconnect() is unsafe during emit()

Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/92eb63547953af2e6514a0fa6c9e109f70643b1b fix issue 16249 - std.signals: disconnect() is unsafe during emit() https://github.com/dlang/phobos/commit/910681ccc97df490871075c6dee6d8ae5db2d298 Merge pull request #4574 from nmtigor/issue_16249