Bug 16514 – std.socket methods are const, and thus cannot be overriden for SSLSocket, for example

commit 1fc5f9b34ca9bb333ee429ab2ca39e07c3304f01 made most of virtual methods of std.socket `const`, and now it is not possible to do any internal housekeeping in overriden methods. bind, connect, listen, accept... this should be reverted.

My fault. I wonder if we could provide protected non-const and public const overloads.

is there any sense in having const methods there at all? anything more complex than "syscall with fd" will require non-const anyway. besides, Socket is heap object, and class with VMT, so it isn't supposed to be lightning-fast anyway. const/nothrow simply adds some "attribute noise" here, without any real purpose. i think. ;-)

It's sometimes useful, such as when it's a field in a const object. Or when you want to use a class as an AA key, to associate some data with it but don't have control over the class's creation.

Introduced in https://github.com/dlang/phobos/pull/4273

i'd say that for AA it is way better (at least in this case) to subclass the thing with new opHash implementation. also, `const` Socket has very little sense: despite being `const`, it is still changing some of it's internal state. slapping `const` usually means "it should not change while i holding it", but this is not the case for open Socket (OS doesn't know about that restriction ;-). i.e. i see no sense in trying to *pretend* that const Socket has any meaning: it is confusing and mostly useless.

Well, even if it doesn't make sense for non-pure methods, there's still some getter methods that should actually be const.

why not `inout` then?

Oops, meant to paste link to PR. https://github.com/dlang/phobos/pull/4858 (In reply to Vladimir Panteleev from comment #1) > I wonder if we could provide protected non-const and public const overloads. No because then you get "class Y use of X.fun() is hidden by Y; use 'alias fun = X.fun;' to introduce base class overload set" errors.

(In reply to Ketmar Dark from comment #8) > why not `inout` then? Well, that still doesn't fix that that PR broke code. With const/non-const overrides I thought that we could just make the const ones public (maybe final) and non-const protected for overriding, but that didn't work.

(In reply to Vladimir Panteleev from comment #10) > With const/non-const overrides Overloads. I meant overloads.

Commit pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/448ddbe2e88d66feb0df3f679bc282840ac4bb26 std.socket: Add test for issue 16514

Commit pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/448ddbe2e88d66feb0df3f679bc282840ac4bb26 std.socket: Add test for issue 16514

Commit pushed to scope at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/448ddbe2e88d66feb0df3f679bc282840ac4bb26 std.socket: Add test for issue 16514

Commit pushed to newCTFE at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/448ddbe2e88d66feb0df3f679bc282840ac4bb26 std.socket: Add test for issue 16514