Bug 16563 – [REG 2.072.0-b1] Wrong struct size/alignment in local struct

/////////////// test.d ////////////// void test() { align(1) struct S { uint i; ubyte b; static assert(S.sizeof == 5); } } ///////////////////////////////////// Introduced in https://github.com/dlang/dmd/pull/5880.

The reason is that the _scope of the AlignDeclarartion does not get set.

The hacky fix for this looks like this: --- a/src/dstruct.d +++ b/src/dstruct.d @@ -299,7 +299,8 @@ extern (C++) class StructDeclaration : AggregateDeclaration if (semanticRun == PASSinit) { protection = sc.protection; - + if (sc && sc.aligndecl && !sc.aligndecl._scope && sc.parent._scope) + sc.aligndecl._scope = sc.parent._scope; alignment = sc.alignment();

When filing regressions for master please use the current development version as tag so we can more easily see which release is affected.

(In reply to Martin Nowak from comment #3) > When filing regressions for master please use the current development > version as tag so we can more easily see which release is affected. I don't think beta 1 was out at that point?

(In reply to uplink.coder from comment #1) > The reason is that the _scope of the AlignDeclarartion does not get set. Yes, setScope isn't called for declarations in functions b/c there are no forward references in functions, hence no scope for early lookups is needed.

Commits pushed to stable at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/07bbf2d0ef547339dee5e886a1a924691c3eb8b8 fix Issue 16563 - wrong alignment in function - function local declarations don't have the setScope pass b/c there are no forward references, therefor AlignDeclaration must not rely on setScope being called - pass Scope to getAlignment instead, either the normal semantic2 one or the one from Scope.alignment https://github.com/dlang/dmd/commit/bf1c25d74964ab3d32d91ecd37f00b99919e5bee Merge pull request #6196 from MartinNowak/fix16563 fix Issue 16563 - wrong alignment in function

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/07bbf2d0ef547339dee5e886a1a924691c3eb8b8 fix Issue 16563 - wrong alignment in function https://github.com/dlang/dmd/commit/bf1c25d74964ab3d32d91ecd37f00b99919e5bee Merge pull request #6196 from MartinNowak/fix16563

Commits pushed to newCTFE at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/07bbf2d0ef547339dee5e886a1a924691c3eb8b8 fix Issue 16563 - wrong alignment in function https://github.com/dlang/dmd/commit/bf1c25d74964ab3d32d91ecd37f00b99919e5bee Merge pull request #6196 from MartinNowak/fix16563