← Back to index | Original Bugzilla link

Bug 16571 – Unittests should not list /tmp/ recursively

Status: RESOLVED
Resolution: FIXED
Severity: enhancement
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2016-10-02T01:22:00Z
Last change time: 2017-01-07T03:02:14Z
Assigned to: nobody
Creator: andrei

Comments

Comment #0 by andrei — 2016-10-02T01:22:51Z

I think I found where the intermittent test failures are: https://github.com/dlang/phobos/blob/master/std/file.d#L3312 There, we list the full content of /tmp, recursively. That's not quite the right thing to do. Not only the run time is arbitrarily slow, but the test may file if certain subdirs are inaccessible.

Comment #1 by github-bugzilla — 2016-10-04T23:28:01Z

Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/b4061155cd667f31b2f7d42ea4ca8c2463f9665b Fix Issue 16571 - Unittests should not list /tmp/ recursively https://github.com/dlang/phobos/commit/08c587ead2156c85c30a2bbc18028b5967010682 Merge pull request #4838 from joakim-noah/temp Fix Issue 16571 - Unittests should not list /tmp/ recursively

Comment #2 by github-bugzilla — 2017-01-07T03:02:14Z

Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/b4061155cd667f31b2f7d42ea4ca8c2463f9665b Fix Issue 16571 - Unittests should not list /tmp/ recursively https://github.com/dlang/phobos/commit/08c587ead2156c85c30a2bbc18028b5967010682 Merge pull request #4838 from joakim-noah/temp