Bug 16678 – [REG] Fix for issue 16193 creates major breakage

Original issue: https://issues.dlang.org/show_bug.cgi?id=16193 Change in https://github.com/dlang/dmd/commit/f7819c898a05d28297024b7355d4ace94f1e4465 (later adjusted in https://github.com/dlang/dmd/commit/f55b4d970b9463fda459fedf13bbcd58369d9ee9) fixed that issue by conservatively allocating a closure unless `opApply` is scope. However, this breaks existing code if closure is attempted on struct with destructor: $ cat sample.d unittest { static struct External { ~this () { } void foo () { } } static struct Iterable { int opApply ( int delegate ( int ) dg ) { return dg(42); } } static void foo (External s1, Iterable s2) { foreach (x; s2) { s1.foo(); } } foo (External.init, Iterable.init); } $ dmd-dev -transition=safe -unittest -main -run sample.d sample.d(20): To enforce @safe compiler allocates a closure unless the opApply() uses 'scope' sample.d(18): Error: variable sample.__unittestL1_1.foo.s1 has scoped destruction, cannot build closure

Introduced via https://github.com/dlang/phobos/pull/4583

(discard previous comment, wrong issue)

Commit pushed to stable at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/8c00c7ea978dad3236148ea6fa57a1a9f8af3186 Merge pull request #6251 from Dicebot/revert-regressions Fix Issue 16678 - [REG] Fix for issue 16193 creates major breakage

Commit pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/8c00c7ea978dad3236148ea6fa57a1a9f8af3186 Merge pull request #6251 from Dicebot/revert-regressions

Commit pushed to scope at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/8c00c7ea978dad3236148ea6fa57a1a9f8af3186 Merge pull request #6251 from Dicebot/revert-regressions

Commit pushed to newCTFE at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/8c00c7ea978dad3236148ea6fa57a1a9f8af3186 Merge pull request #6251 from Dicebot/revert-regressions