← Back to index | Original Bugzilla link

Bug 16999 – takeOne popFront/Back does not pop the source range

Status: RESOLVED
Resolution: WORKSFORME
Severity: minor
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2016-12-22T06:03:00Z
Last change time: 2017-07-02T22:59:21Z
Assigned to: Ajieskola
Creator: Ajieskola

Comments

Comment #0 by Ajieskola — 2016-12-22T06:03:16Z

This makes it inconsistent with take or takeExactly with length 1. Not on most occasions, but if using a reference range it does matter. PR here: https://github.com/dlang/phobos/pull/4984

Comment #1 by github-bugzilla — 2017-01-26T22:08:02Z

Commit pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/d60f32c3b92a44e6b9b7f6e9183b298c47d1f71d Merge pull request #4984 from dukc/takeOneFix Bugfix for takeOne (issue 16999)

Comment #2 by github-bugzilla — 2017-02-24T18:15:33Z

Commit pushed to newCTFE at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/d60f32c3b92a44e6b9b7f6e9183b298c47d1f71d Merge pull request #4984 from dukc/takeOneFix

Comment #3 by github-bugzilla — 2017-03-22T12:21:55Z

Commit pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/d60f32c3b92a44e6b9b7f6e9183b298c47d1f71d Merge pull request #4984 from dukc/takeOneFix

Comment #4 by dlang-bugzilla — 2017-07-02T22:59:21Z

PR was merged, so I assume this is now fixed.