Bug 17044 – Bugzilla integration fails with reverts and multiple branches
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
tools
Product
D
Version
D2
Platform
All
OS
All
Creation time
2016-12-30T17:14:06Z
Last change time
2020-06-04T17:32:00Z
Assigned to
Seb
Creator
Dicebot
Comments
Comment #0 by public — 2016-12-30T17:14:06Z
Now that there are at least two development branches (`master` and `stable`), simplicity of GitHub bugzilla integration becomes a problem.
Consider https://issues.dlang.org/show_bug.cgi?id=16193 - it got originally fixed with a commit mentioning "fix Issue 16193". Later it got reverted (with an auto-generated commit saying "Revert "fix Issue 16193 ...") and matching issues was reopened.
But when revert commit got merged into another branch, bugzilla integration hook has detected the very same "fix Issue 16193" substring and closed issue again as fixed (but it wasn't).
Best solution would be for hook to actually recognize revert commits as having inverse effect of "fixes" mention but I don't know if it can be configured as such.
Comment #1 by dfj1esp02 — 2017-01-17T16:28:12Z
Or just do nothing for merges.
Comment #2 by greensunny12 — 2018-01-18T22:27:47Z
The Bugzilla integration has been changed to be only active for `master`. This should reduce the noise significantly.
Comment #3 by pro.mathias.lang — 2020-06-04T17:32:00Z