Bug 17074 – extern(C++, keyword) crashes compiler

Some random examples, just to show that any tokenized keyword can trigger it. extern(C++, cast) void crash(); extern(C++, __parameters) void crash(); extern(C++, __MODULE__) void crash(); extern(C++, macro) void crash(); extern(C++, ...) void crash();

Putting as regression as adding `extern(C++, nspace)` support would have been the reason this happens, and it looks like was implemented without proper handling of syntax errors.

Commits pushed to stable at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/e4516073a3e0d5d92499fc6e1a5b184eb4e87f31 Fix Issue 17074: extern(C++, keyword) crashes compiler This change unsets 'idents' if an error occurred parsing the C++ namespace, so that the later check for 'assert(idents.dim)' never fires. https://issues.dlang.org/show_bug.cgi?id=17074 https://github.com/dlang/dmd/commit/b35ec9c94a14d226dcbb5758eedd8e7d2cc4cb53 Merge pull request #6415 from ibuclaw/issue17074 Fix Issue 17074: extern(C++, keyword) crashes compiler

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/e4516073a3e0d5d92499fc6e1a5b184eb4e87f31 Fix Issue 17074: extern(C++, keyword) crashes compiler https://github.com/dlang/dmd/commit/b35ec9c94a14d226dcbb5758eedd8e7d2cc4cb53 Merge pull request #6415 from ibuclaw/issue17074

Commits pushed to newCTFE at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/e4516073a3e0d5d92499fc6e1a5b184eb4e87f31 Fix Issue 17074: extern(C++, keyword) crashes compiler https://github.com/dlang/dmd/commit/b35ec9c94a14d226dcbb5758eedd8e7d2cc4cb53 Merge pull request #6415 from ibuclaw/issue17074

Commit pushed to dmd-cxx at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/c8f1a623fe76ee302c3dcfcfae162a1037c18cf4 Issue 17074: extern(C++, keyword) crashes compiler