← Back to index | Original Bugzilla link

Bug 17340 – [REG 2.074.0] isNumeric!bool should not be true

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2017-04-22T01:02:33Z
Last change time
2018-01-05T13:28:28Z
Assigned to
No Owner
Creator
thomas.bockman

Comments

Comment #0 by thomas.bockman — 2017-04-22T01:02:33Z
A regression was introduced in this commit: https://github.com/dlang/phobos/commit/a07517abae8dce9e0687913b1a03c942aed60dce std.traits.isNumeric!bool should be false.
Comment #1 by thomas.bockman — 2017-04-22T01:07:42Z
The new (wrong) behaviour was also retroactively added to the documentation in a later commit: https://github.com/dlang/phobos/commit/118f2d773317d0da76c0d9054e7bcddd2e83f887 However, prior to DMD 2.074 isNumeric did not work this way. It's a (presumably accidental) breaking change.
Comment #2 by thomas.bockman — 2017-04-22T01:12:28Z
I submitted a fix: https://github.com/dlang/phobos/pull/5343
Comment #3 by github-bugzilla — 2017-04-27T19:17:11Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e Fix issue 17340 - isNumeric!bool should not be true https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b Merge pull request #5343 from tsbockman/is_bool_numeric Fix issue 17340 - isNumeric!bool should not be true
Comment #4 by github-bugzilla — 2017-05-29T23:02:14Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e Fix issue 17340 - isNumeric!bool should not be true https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b Merge pull request #5343 from tsbockman/is_bool_numeric
Comment #5 by github-bugzilla — 2018-01-05T13:28:28Z
Commits pushed to dmd-cxx at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e Fix issue 17340 - isNumeric!bool should not be true https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b Merge pull request #5343 from tsbockman/is_bool_numeric