Bug 17494 – Do not execute scope(...) if an Error exception has been thrown

Not cleaning up after an Error is thrown is allowed by the D spec. This enhancement allows much better code to be generated for `nothrow` code when `scope` is used. It will also not unwind declarations with destructors in `nothrow` code when Errors are thrown. It also fixes regression https://issues.dlang.org/show_bug.cgi?id=17493

Test Case from Vladimir https://github.com/dlang/dmd/pull/6816#issuecomment-307657520 struct S { ~this() {} } class C { S s; this() nothrow {} }

Commit pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/558773e64d42d56ad02970adfdc1371311ca3291 add test cases for existing production code - fixes Issues 17494, 17505, 17506

Commit pushed to newCTFE at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/558773e64d42d56ad02970adfdc1371311ca3291 add test cases for existing production code

This issue was never fixed: ===================================== import core.stdc.stdio : puts; void main() { scope (exit) puts("Hello, World!"); throwError(); } void throwError() { throw new Error(""); } ===================================== Hello, World! object.Error@(0) ---------------- onlineapp.d:11 void onlineapp.throwError() [0x5579194b2bea] onlineapp.d:6 _Dmain [0x5579194b2b78]

@WalterBright updated dlang/dmd pull request #6896 "fix Issue 17494 - Do not execute scope(...) if an Error exception has…" fixing this issue: - fix Issue 17494 - Do not execute scope(...) if an Error exception has been thrown https://github.com/dlang/dmd/pull/6896

THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dmd/issues/19261 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB