← Back to index | Original Bugzilla link

Bug 17525 – std.algorithm.searching.skipOver should have a single argument with pred version

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2017-06-19T15:14:17Z
Last change time
2018-01-05T13:29:48Z
Assigned to
No Owner
Creator
Jack Stouffer

Comments

Comment #0 by jack — 2017-06-19T15:14:17Z
A la startsWith and endsWith, I should be able to do the following with skipOver auto s = "\tvalue"; assert(s.skipOver!isWhite.equal("value"));
Comment #1 by razvan.nitu1305 — 2017-07-05T07:44:18Z
skipOver returns a bool value and so do startsWith and endsWith, so you can't equal with "value". But I think that adding an overload to support the construction: auto s = "\tvalue"; assert(s.skipOver!isWhite && s.equals("value")); is useful and offers consistency.
Comment #2 by razvan.nitu1305 — 2017-07-05T08:42:04Z
PR : https://github.com/dlang/phobos/pull/5543
Comment #3 by github-bugzilla — 2017-07-07T06:35:09Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/1d1b42f413c7b929dcd5c3081dd181638a912fd6 Fix Issue 17525 - std.algorithm.skipOver should have a single argument with pred version https://github.com/dlang/phobos/commit/37d15a89c52967006585cb088dbe008e901aa123 Merge pull request #5543 from RazvanN7/Issue_17525 Fix Issue 17525 - std.algorithm.searching.skipOver should have a single argument with pred version merged-on-behalf-of: Sebastian Wilzbach <[email protected]>
Comment #4 by github-bugzilla — 2017-08-16T13:23:19Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/1d1b42f413c7b929dcd5c3081dd181638a912fd6 Fix Issue 17525 - std.algorithm.skipOver should have a single argument with pred version https://github.com/dlang/phobos/commit/37d15a89c52967006585cb088dbe008e901aa123 Merge pull request #5543 from RazvanN7/Issue_17525
Comment #5 by github-bugzilla — 2018-01-05T13:29:48Z
Commits pushed to dmd-cxx at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/1d1b42f413c7b929dcd5c3081dd181638a912fd6 Fix Issue 17525 - std.algorithm.skipOver should have a single argument with pred version https://github.com/dlang/phobos/commit/37d15a89c52967006585cb088dbe008e901aa123 Merge pull request #5543 from RazvanN7/Issue_17525