← Back to index | Original Bugzilla link

Bug 17565 – Rename theAllocator to threadAllocator

Status: RESOLVED
Resolution: WONTFIX
Severity: enhancement
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2017-06-28T12:46:00Z
Last change time: 2017-07-05T07:05:40Z
Assigned to: nobody
Creator: sludwig

Comments

Comment #0 by sludwig — 2017-06-28T12:46:42Z

The current name doesn't convey the message that this is a thread-local allocator. The relation to processAllocator also isn't quite clear. The private variable that backs theAllocator is already named _threadAllocator and doing the same for the accessor property is arguably the most logical choice.

Comment #1 by razvan.nitu1305 — 2017-07-05T06:57:11Z

PR : https://github.com/dlang/phobos/pull/5542

Comment #2 by sludwig — 2017-07-05T07:05:40Z

Rejected, because the intention is to explicitly drive people to use theAllocator by default. This currently has some safety concerns, but hopefully most of them will be mitigated by Druntime/Phobos thread API changes and possibly language changes in the future. Related discussion in https://github.com/dlang/phobos/pull/5520