Bug 17680 – Broken ddmd source links in documentation

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
dlang.org
Product
D
Version
D2
Platform
All
OS
All
Creation time
2017-07-24T22:20:21Z
Last change time
2017-12-21T14:40:57Z
Keywords
pull
Assigned to
No Owner
Creator
Ali Cehreli

Comments

Comment #0 by acehreli — 2017-07-24T22:20:21Z
1) Many or all ddmd documentation source code links are broken. For example, the following page https://dlang.org/phobos/ddmd_access.html includes this link https://github.com/dlang/dmd/blob/master/src/dmd/access.d which is invalid. Instead, the following seems to work (dmd -> ddmd): https://github.com/dlang/dmd/blob/master/src/ddmd/access.d 2) The following page has newlines inside License: and Source: links, breaking them in the browser: https://dlang.org/phobos/ddmd_backend_cdef.html Ali
Comment #1 by dlang-bugzilla — 2017-07-26T09:18:20Z
Comment #2 by dlang-bugzilla — 2017-07-26T09:30:29Z
https://github.com/dlang/dmd/pull/7030 Pretty please file separate issues for separate issues next time!
Comment #3 by github-bugzilla — 2017-07-26T15:43:01Z
Commits pushed to master at https://github.com/dlang/dlang.org https://github.com/dlang/dlang.org/commit/fc7a8aeadeaf3782ffd60e802d705bf7ac0f3e0d Issue 17680 - fix DMDSRC https://github.com/dlang/dlang.org/commit/f2ecd76842a28bfa15acf72460a77f93010bcfdd Merge pull request #1843 from wilzbach/fix-17680 Issue 17680 - fix DMDSRC merged-on-behalf-of: MetaLang <[email protected]>
Comment #4 by github-bugzilla — 2017-08-08T18:25:58Z
Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/2501a047179eba522a73a91bd049d63772d5f48f Use DDoc syntax for license links Partial fix for Issue 17680. https://github.com/dlang/dmd/commit/1d2bf7149eba8ad8d8bb262234c23cbaaefc2b7b Use DDoc syntax for source links Partial fix for Issue 17680.
Comment #5 by github-bugzilla — 2017-08-14T23:56:14Z
Comment #6 by github-bugzilla — 2017-08-16T13:23:47Z
Comment #7 by github-bugzilla — 2017-08-16T13:24:00Z
Comment #8 by greensunny12 — 2017-12-21T14:40:57Z
Somehow the commits didn't close this issue :/ Anyhow it got broken during the ddmd -> dmd transition, but it's fixed on master: https://dlang.org/phobos-prerelease/dmd_access.html https://dlang.org/phobos-prerelease/dmd_backend_cdef.html And will be on stable soon.