Bug 17711 – std.array.byPair should be usable with const AA

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2017-08-01T22:53:39Z
Last change time
2018-01-05T13:30:56Z
Keywords
pull
Assigned to
No Owner
Creator
hsteoh

Comments

Comment #0 by hsteoh — 2017-08-01T22:53:39Z
Code: ------ import std.array; const(int[string]) aa = [ "abc": 123 ]; auto r = aa.byPair; ------ This code ought to compile, but doesn't, because const(int[string]) does not match the function declaration `auto byPair(K,V)(Value[Key] aa)`. However, the implementation actually supports iterating over const AA's just fine. We just need to declare the function differently so that it will match a const AA type: ------ auto byPair(AA : V[K], V, K)(AA aa) ------
Comment #1 by hsteoh — 2017-08-01T23:01:20Z
Comment #2 by github-bugzilla — 2017-08-02T08:55:55Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/0c0aed8662dcd3579de4521c98ce0facbfd774fe Fix issue 17711: std.array.byPair ought to work with const AA's. https://github.com/dlang/phobos/commit/e4e858bf50e01f7bc9566b6fd56d9e3ff867d1a8 Merge pull request #5668 from quickfur/issue17711 Fix issue 17711: std.array.byPair ought to work with const AA's. merged-on-behalf-of: Petar Kirov <[email protected]>
Comment #3 by github-bugzilla — 2017-08-16T13:24:31Z
Commits pushed to stable at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/0c0aed8662dcd3579de4521c98ce0facbfd774fe Fix issue 17711: std.array.byPair ought to work with const AA's. https://github.com/dlang/phobos/commit/e4e858bf50e01f7bc9566b6fd56d9e3ff867d1a8 Merge pull request #5668 from quickfur/issue17711
Comment #4 by github-bugzilla — 2018-01-05T13:30:56Z
Commits pushed to dmd-cxx at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/0c0aed8662dcd3579de4521c98ce0facbfd774fe Fix issue 17711: std.array.byPair ought to work with const AA's. https://github.com/dlang/phobos/commit/e4e858bf50e01f7bc9566b6fd56d9e3ff867d1a8 Merge pull request #5668 from quickfur/issue17711