Bug 17805 – -dirty flag on dmd's version

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
Linux
Creation time
2017-09-04T18:18:17Z
Last change time
2017-10-02T20:54:46Z
Assigned to
No Owner
Creator
Martin Nowak

Comments

Comment #0 by code — 2017-09-04T18:18:17Z
Since 2.076.0 dmd's version has the -dirty flag set. We've changed the version determinatio https://github.com/dlang/dmd/commit/09cc628724be87a6e317223059202ea652630ef5 and now the release build script seems to pick up the -dirty from it's git repo. There shouldn't be any difference though, the only thing the build script changes is to overwrite the VERSION file.
Comment #1 by github-bugzilla — 2017-09-04T21:07:24Z
Commits pushed to stable at https://github.com/dlang/installer https://github.com/dlang/installer/commit/8715780b3085d4427ec14960ca5b1afe9820ed45 fix Issue 17805 - -dirty flag on dmd's version - stop overwriting dmd's VERSION file for release building and instead verify that it matches the gitTag - -dirty flag of git describe was caused by newline mismatch in VERSION file https://github.com/dlang/installer/commit/f1443c04d1066b33823e79e6447902de9cda0836 Merge pull request #250 from MartinNowak/fix17805 fix Issue 17805 - -dirty flag on dmd's version
Comment #2 by github-bugzilla — 2017-10-02T20:54:46Z