Bug 18024 – checkedint.Abort and checkedint.Warn should be @safe

void main(string[] args) @safe @nogc nothrow pure { import std.experimental.checkedint : checked; auto f = (2.checked + 3).get; } foo.d(4): Error: pure function 'D main' cannot call impure function 'std.experimental.checkedint.Checked!(int, Abort).Checked.opBinary!("+", int).opBinary' foo.d(4): Error: @safe function 'D main' cannot call @system function 'std.experimental.checkedint.Checked!(int, Abort).Checked.opBinary!("+", int).opBinary' foo.d(4): Error: @nogc function 'D main' cannot call non-@nogc function 'std.experimental.checkedint.Checked!(int, Abort).Checked.opBinary!("+", int).opBinary' foo.d(4): Error: function std.experimental.checkedint.Checked!(int, Abort).Checked.opBinary!("+", int).opBinary is not nothrow

Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different?

> Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different? Well, the default hook Abort just SEGFAULTs / assert(0)s will fullfils all the attributes given.

(In reply to Seb from comment #2) > > Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different? > > Well, the default hook Abort just SEGFAULTs / assert(0)s will fullfils all > the attributes given. Don't forget it also prints to stderr, which is why it's @system impure gc and throws

The problem with trying to make Warn @safe is File is still unsafe and will be for the foreseeable future. IMO, Abort should be modified to not use Warn, and a new Hook called debug should give the same behavior as Abort has now. That way, by default checked is @nogc @safe nothrow pure

> Don't forget it also prints to stderr, which is why it's @system impure gc and throws Yeah I did forget about this when I opened the issue (didn't had time to dive into this then). Anyhow it `Warn` can easily be made @safe: PR https://github.com/dlang/phobos/pull/5928

> The problem with trying to make Warn @safe is File is still unsafe and will be for the foreseeable future. Well, but we can use the same "trick" / "workaround" as used for stdout? > IMO, Abort should be modified to not use Warn, and a new Hook called debug should give the same behavior as Abort has now. That way, by default checked is @nogc @safe nothrow pure That sounds very reasonable!

See also https://github.com/dlang/phobos/pull/6550 for yet another PR on this problem

@n8sh created dlang/phobos pull request #7909 "checkedint.Abort and checkedint.Warn should be `@safe`" fixing this issue: - Fix Issue 18024 - checkedint.Abort and checkedint.Warn should be `@safe` https://github.com/dlang/phobos/pull/7909

dlang/phobos pull request #7909 "checkedint.Abort and checkedint.Warn should be `@safe`" was merged into master: - 7580f74c9af0afd266f730d8ab3a37c61e06e35c by Nathan Sashihara: Fix Issue 18024 - checkedint.Abort and checkedint.Warn should be `@safe` https://github.com/dlang/phobos/pull/7909