Bug 18243 – selective import + overload = private visibility

module a; private import std.math: isNaN; //custom overload public bool isNaN(int i) { return false; } ============================= module b; import a; void foo() { bool b = isNaN(float.nan); //compiles successfully calling std.math.isNaN even it should not be visible. }

See also: https://issues.dlang.org/show_bug.cgi?id=12359

*** This issue has been marked as a duplicate of issue 17630 ***

I'm re-opening this as its slightly different to 17630 and it's probably worthwhile to add both tests to the testsuite once this gets fixed.

The problem here is that overload sets do not have a protection attribute. Moreover the symbolIsVisible function in the compiler takes a symbol and then checks if the most visible overload of that particular overload set is visible. This, obviously is problematic, since in this case std.math.isNaN is found and when the check for visibility is made the public overload is considered.

PR : https://github.com/dlang/dmd/pull/7766

Commits pushed to master at https://github.com/dlang/dmd https://github.com/dlang/dmd/commit/a71ede3ac0ab8320cbd191d0c8cac4de402ec585 Fix Issue 18243 - selective import + overload = private visibility https://github.com/dlang/dmd/commit/ccbaaa14fa65c5066c832e222a14d190389e2470 Merge pull request #7766 from RazvanN7/Issue_18243 Fix Issue 18243 - selective import + overload = private visibility