Bug 18348 – Color highlighting of backticks has issues

Status
RESOLVED
Resolution
WORKSFORME
Severity
normal
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
Linux
Creation time
2018-02-01T08:32:40Z
Last change time
2019-09-05T04:19:36Z
Keywords
pull
Assigned to
No Owner
Creator
Seb

Comments

Comment #0 by greensunny12 — 2018-02-01T08:32:40Z
Consider: --- void main() { "aa".foo; } --- > rdmddev foo.d foo.d(3): Error: no property foo for type string Expected: foo to be hightlighted, but only Error is. > rdmddev -color=off foo.d foo.d(3): Error: no property 'foo' for type string Visible on CLI and run.dlang.io: https://run.dlang.io/is/ioU894
Comment #1 by ag0aep6g — 2018-02-01T15:54:20Z
(In reply to Seb from comment #0) > > rdmddev foo.d > foo.d(3): Error: no property foo for type string > > Expected: foo to be hightlighted, but only Error is. For me, "Error" is red and bold, and "foo" and "string" are bold. > > rdmddev -color=off foo.d > foo.d(3): Error: no property 'foo' for type string I get: "Error: no property `foo` for type `string`". Maybe your rdmddev is not up to date? I've tested with DMD64 D Compiler v2.078.1-625-g7f270134f. > Visible on CLI and run.dlang.io: https://run.dlang.io/is/ioU894 On run.dlang.io, "foo" and "string" are wrapped in `<span class="ansi-bright-white-fg">...</span>` and the color is black instead of the usual almost black #333. That's really subtle, but it's there. Maybe it should also be bold. Closing as WORKSFORME. Reopen if I'm missing something.
Comment #2 by greensunny12 — 2018-02-01T16:08:57Z
That's how it looks for me: https://imgur.com/8qcFYJA (compiled from master today) I can also show the problem better with a test case - in fact even with a PR https://github.com/dlang/dmd/pull/7822 (sorry - totally forgot to mention the PR here) With the linked PR: https://imgur.com/a/JnE8l
Comment #3 by pro.mathias.lang — 2019-09-05T04:19:36Z
Just tested this, works4me