Bug 18715 – Non-documented unittests should not use unpredictableSeed or default Random alias

Status
NEW
Severity
minor
Priority
P3
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2018-04-03T12:41:32Z
Last change time
2024-12-01T16:33:22Z
Assigned to
No Owner
Creator
Nathan S.
Moved to GitHub: phobos#10327 →

Comments

Comment #0 by n8sh.secondary — 2018-04-03T12:41:32Z
Rationale: https://github.com/dlang/phobos/pull/6410#discussion_r178660995 >Use a fixed seed and a fixed engine, everything else might lead to random coverage changes. Exceptions are made for public unittests that may be meant to demonstrate use of unpredictableSeed and/or the default Random.
Comment #1 by n8sh.secondary — 2018-04-03T12:48:28Z
Comment #2 by github-bugzilla — 2018-04-04T23:41:36Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/c1d1c0e874b16fe2717e2c62b30c7c3f03e68446 Issue 18715 - Non-documented unittests should not use unpredictableSeed or default Random alias https://github.com/dlang/phobos/commit/c1fcea4fdfc4c1b56278c196dbd8908c34d8c11c Merge pull request #6414 from n8sh/remove-unpredictableseed-from-unittests Issue 18715 - Non-documented unittests should not use unpredictableSeed or default Random alias merged-on-behalf-of: Nathan Sashihara <[email protected]>
Comment #3 by bugzilla — 2019-12-08T08:07:35Z
I found three such tests remaining: One in std/uuid.d and two in std/random.d. Should these three also be fixed? Or can we close this issue?
Comment #4 by robert.schadek — 2024-12-01T16:33:22Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/phobos/issues/10327 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB