Bug 18818 – VariantN has unittests that are compiled into user modules

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2018-05-02T05:29:30Z
Last change time
2019-03-31T13:06:21Z
Keywords
pull
Assigned to
No Owner
Creator
Neia Neutuladh

Comments

Comment #0 by dhasenan — 2018-05-02T05:29:30Z
The offending tests are defined at variant.d lines 708, 741, and 1132. Phobos unittests should not run in a user executable. These tests should probably be guarded behind version(StdDdoc). (They were formerly erroneously gated behind version(StdUnittest), but that was removed.)
Comment #1 by giles.bathgate+dlang — 2018-05-04T09:36:02Z
For reference: StdUnittest was added in this PR https://github.com/dlang/phobos/pull/5927 StdUnittest was removed in this PR https://github.com/dlang/phobos/pull/6202
Comment #2 by dlang-bot — 2019-03-31T05:23:15Z
@Kriyszig created dlang/phobos pull request #6942 "variant.d: Gated unittests behind version(StdDdoc)" fixing this issue: - variant.d: Gated unittests behind version(StdDdoc) Prevents compilation of unittests into user modules fix Issue 18818 - unittests are compiled into user modules https://github.com/dlang/phobos/pull/6942
Comment #3 by dlang-bot — 2019-03-31T13:06:21Z
dlang/phobos pull request #6942 "variant.d: Gated unittests behind version(StdDdoc)" was merged into stable: - 5c8888f4022512b5c3eee048c642210ed05507a9 by Kriyszig: variant.d: Gated unittests behind version(StdDdoc) Prevents compilation of unittests into user modules fix Issue 18818 - unittests are compiled into user modules https://github.com/dlang/phobos/pull/6942