Bug 19135 – std.json : JSON_TYPE does not match D Style.

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
x86_64
OS
Linux
Creation time
2018-08-02T07:00:59Z
Last change time
2018-08-14T18:04:34Z
Assigned to
No Owner
Creator
FeepingCreature

Comments

Comment #0 by default_357-line — 2018-08-02T07:00:59Z
std.json.JSON_TYPE is not conformant with the D Style Guidelines https://dlang.org/dstyle.html : * The names of user-defined types should be PascalCased * The members of enums should be camelCased, so their first letter is lowercase. * If a name would conflict with a keyword, and it is desirable to use the keyword rather than pick a different name, a single underscore ‘_’ should be appended to it. Names should not be capitalized differently in order to avoid conflicting with keywords.
Comment #1 by github-bugzilla — 2018-08-14T18:04:33Z
Commits pushed to master at https://github.com/dlang/phobos https://github.com/dlang/phobos/commit/fbd094737fa1130ab53f7fcc17b36f8881e10790 Fix Issue 19135 Rewrite std.json.JSON_TYPE to be CamelCase with lowercase members, with underscore attached to avoid keyword collision. Deprecate the old type via alias. https://github.com/dlang/phobos/commit/a26ccc6f4cd6cac93b9361233fd093b72c09a869 Merge pull request #6649 from FeepingCreature/fix/issue-19135-rewrite-json_type-to-match-style-guidelines Fix Issue 19135: Rename std.json.JSON_TYPE to JsonType with lowercase attributes merged-on-behalf-of: Petar Kirov <[email protected]>