Bug 19386 – Destructor not called when constructed inside if condition, leading to memory leak

Destructor is not called when an object is constructed inside of an if statement and opCast!bool returns false. Reproduction: struct Thing { this(int* i) { ptr = i; (*ptr)++; } ~this() { (*ptr)--; } T opCast(T:bool)() { return false; } int* ptr; } Thing makeThing(int* p) { return Thing(p); } void main() { int i; { if(auto t = makeThing(&i)) { import std.stdio; writeln("hello?"); } } assert(i == 0); } Observed output: [email protected](24): Assertion failure Expected output:

Moving object creation outside of the if statement works as intended. struct Thing { this(int* i) { ptr = i; (*ptr)++; } ~this() { (*ptr)--; } T opCast(T:bool)() { return false; } int* ptr; } Thing makeThing(int* p) { return Thing(p); } void main() { int i; { auto t = makeThing(&i); if(t) { import std.stdio; writeln("hello?"); } } assert(i == 0); } Observed output:

dlang/dmd pull request #9830 "Fix issue 19386 - Destructor not called when constructed inside if condition" was merged into stable: - 9d4f5555118670ef68416a0d13108e3cdcf13271 by سليمان السهمي (Suleyman Sahmi): Fix issue 19386 - Destructor not called when constructed inside if condition This happens when the if condition evaluates to false at runtime https://github.com/dlang/dmd/pull/9830