Bug 19454 – Name collisions with unnamed function parameters

Example: --- void foo(int _param_1, int) {} --- Result is a compile error: Error: function `scratch.foo` parameter foo._param_1 is already defined Double-underscore identifiers are reserved by the compiler, but other identifiers are not. The fix is to change _param_[index] to __param_[index], presumably. That won't change the name collision, but it will at least move it to "here be dragons" territory instead of "this looks like it should work".

--- diff --git a/src/dmd/semantic3.d b/src/dmd/semantic3.d index 7b08f3639..6e34ed7db 100644 --- a/src/dmd/semantic3.d +++ b/src/dmd/semantic3.d @@ -439,7 +439,7 @@ private extern(C++) final class Semantic3Visitor : Visitor /* Generate identifier for un-named parameter, * because we need it later on. */ - fparam.ident = id = Identifier.generateId("_param_", i); + fparam.ident = id = Identifier.generateId("__param_", i); stc |= STC.temp; } Type vtype = fparam.type; ---

*** Issue 19578 has been marked as a duplicate of this issue. ***

@dkorpel created dlang/dmd pull request #15153 "Fix 19454 - Name collisions with unnamed function parameters" fixing this issue: - Fix 19454 - Name collisions with unnamed function parameters https://github.com/dlang/dmd/pull/15153

dlang/dmd pull request #15153 "Fix 19454 - Name collisions with unnamed function parameters" was merged into master: - ba2f9222fd46cb450332dbad776b19767d3f2d42 by Dennis Korpel: Fix 19454 - Name collisions with unnamed function parameters https://github.com/dlang/dmd/pull/15153