Bug 19468 – Improve cyclic dependency error message

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
All
Creation time
2018-12-06T18:38:31Z
Last change time
2018-12-06T20:33:52Z
Keywords
pull
Assigned to
No Owner
Creator
hsteoh

Comments

Comment #0 by hsteoh — 2018-12-06T18:38:31Z
The compiler error message about cyclic dependencies between modules should indicate that it's a cyclic dependency between module *ctors* or *dtors*, otherwise users could be misled into trying to fix the non-existent problem of cyclic imports. See also: https://issues.dlang.org/show_bug.cgi?id=5053 (Note: this is NOT the same bug; the latter refers to the error message emitted by druntime at runtime. This present bug is concerned with the *compiler* error message.)
Comment #1 by hsteoh — 2018-12-06T18:54:11Z
Correction: actually, there is no such error message in the compiler. This is a druntime bug: the wording of the error message should be made clearer.
Comment #2 by hsteoh — 2018-12-06T18:57:45Z
Comment #3 by github-bugzilla — 2018-12-06T20:33:51Z
Commits pushed to master at https://github.com/dlang/druntime https://github.com/dlang/druntime/commit/27005c6a2afecf49b2e730a2fa729af112304ea9 Fix issue 19468: improve cyclic dependency error message. https://github.com/dlang/druntime/commit/954c7216fbc918ce68126027c778a4520327871b Merge pull request #2397 from quickfur/issue19468 Fix issue 19468: improve cyclic dependency error message. merged-on-behalf-of: Jacob Carlborg <[email protected]>