Bug 19645 – Default parameters not checked for @safe

Reported by ag0aep6g: import std.stdio; @safe: immutable x = 42; void main() { *f() = 7; writeln(x); // 42 writeln(*&x); // 7 } int* f(int* y = cast(int*) &x) { return y; }

Also: --- shared int b; pure void g(int a=b){} pure void f() { g(); } ---

(In reply to anonymous4 from comment #1) > Also: > --- > shared int b; > pure void g(int a=b){} > pure void f() > { > g(); > } > --- Existing violation in phobos : https://github.com/dlang/phobos/blob/master/std/path.d#L2741

relativePath is inferred as pure too

@RazvanN7 created dlang/dmd pull request #9428 " Fix Issue 19645 - Default parameters not checked for @safe" fixing this issue: - Fix Issue 19645 - Fix Issue 19645 - Fix Issue 19645 - Default parameters not checked for @safe https://github.com/dlang/dmd/pull/9428

To be specific: ----- module m; shared int b; pure void g(int a=b){} ----- import m; int b; pure void f() { g(); } ----- should be compiled as if written: ----- module m; shared int b; pure void g(int a=b){} ----- import m; int b; pure void f() { g(m.b); // pick m.b, not local b } -----

@WalterBright created dlang/dlang.org pull request #2607 "fix Issue 19645 - Default parameters not checked for @safe" fixing this issue: - fix Issue 19645 - Default parameters not checked for @safe https://github.com/dlang/dlang.org/pull/2607

Spec fix: https://github.com/dlang/dlang.org/pull/2607

dlang/dlang.org pull request #2607 "Function Default Parameters are underspecified" was merged into master: - 9100e8d3630f1f533167467989104f3f86846474 by Walter Bright: fix Issue 19645 - Default parameters not checked for @safe https://github.com/dlang/dlang.org/pull/2607

Reopening. Walter's spec fix was merged, but that doesn't fix the issue in DMD.

*** Issue 20726 has been marked as a duplicate of this issue. ***

This is also an issue for __gshared default parameters and particularly auto ref __gshared parameters. See: https://issues.dlang.org/show_bug.cgi?id=20726

Although this is specifically for @safe, the broader issue is a duplicate of 11048. *** This issue has been marked as a duplicate of issue 11048 ***