Bug 19718 – DMD 2.085 changes to gsroa make DCD crashing
Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2019-03-05T13:59:03Z
Last change time
2019-03-05T23:43:45Z
Keywords
pull
Assigned to
No Owner
Creator
Basile-z
Comments
Comment #0 by b2.temp — 2019-03-05T13:59:03Z
shell script to reproduce the issue and verify that it's fixed:
---
killall dcd-server
if [[ ! -d dcd ]]; then
git clone https://github.com/dlang-community/dcd.git
git submodule update --init
fi
cd dcd
if [[ ! -f bin/dcd-server ]]; then
make
fi
pos=`grep -boa "ASTVisitor" libdparse/src/dparse/ast.d | head -1`
pos=`echo $pos | grep -o [0-9]*`
let pos++
bin/dcd-server &
sleep 2
res=`bin/dcd-client --doc -c$pos libdparse/src/dparse/ast.d`
if [[ ${res} == "Implements the \$(LINK2 http://en.wikipedia.org/wiki/Visitor_pattern, Visitor Pattern)\nfor the various AST classes" ]]; then
echo "FIXED !!"
fi
---
Note that you'll certainly have to tweak the makefile of DCD in order to use the devel version of DMD, line 9 (DMD := <your devel dmd here...>)
Manual digging in the stable branch shows that the regression come from this DMD PR: https://github.com/dlang/dmd/pull/9281
Comment #1 by dlang-bot — 2019-03-05T20:45:19Z
@Basile-z created dlang/dmd pull request #9422 "fix issue 19718 - DMD 2.085 changes to gsroa make DCD crashing" fixing this issue:
- fix issue 19718 - DMD 2.085 changes to gsroa make DCD crashing
https://github.com/dlang/dmd/pull/9422
Comment #2 by dlang-bot — 2019-03-05T23:43:45Z
dlang/dmd pull request #9422 "fix issue 19718 - DMD 2.085 changes to gsroa make DCD crashing" was merged into stable:
- dab6aa485bb69ecf9d5b4da7617ec9e71d8ac8cc by Basile Burg:
fix issue 19718 - DMD 2.085 changes to gsroa make DCD crashing
https://github.com/dlang/dmd/pull/9422