Bug 19734 – isDataseg returns true for non-static declarations

Status
RESOLVED
Resolution
FIXED
Severity
blocker
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2019-03-13T10:31:29Z
Last change time
2019-03-15T11:52:42Z
Keywords
pull
Assigned to
No Owner
Creator
Iain Buclaw

Comments

Comment #0 by ibuclaw — 2019-03-13T10:31:29Z
In the following example: class A { extern { void f() { int a; } } } All declarations enclosed inside 'extern' are marked as STCextern, even the 'this' parameter, making isDataseg() wrongly return true.
Comment #1 by dlang-bot — 2019-03-13T13:39:04Z
@ibuclaw created dlang/dmd pull request #9451 "fix Issue 19734 - isDataseg returns true for non-static declarations" fixing this issue: - fix Issue 19734 - isDataseg returns true for non-static declarations https://github.com/dlang/dmd/pull/9451
Comment #2 by dlang-bot — 2019-03-14T08:02:21Z
dlang/dmd pull request #9451 "fix Issue 19734 - isDataseg returns true for non-static declarations" was merged into master: - 25150635639e2f92df48ebfb07872af71bfd380e by Iain Buclaw: fix Issue 19734 - isDataseg returns true for non-static declarations https://github.com/dlang/dmd/pull/9451
Comment #3 by dlang-bot — 2019-03-15T11:52:42Z
dlang/dmd pull request #9452 "[dmd-cxx] fix Issue 19734 and 19735" was merged into dmd-cxx: - f62400eac68ae703b1806e928029f8ca3258ec43 by Iain Buclaw: fix Issue 19734 - isDataseg returns true for non-static declarations https://github.com/dlang/dmd/pull/9452