Bug 19856 – [aApplycd2]: foreach (int) doesn't work on BigEndian targets

In the following code, the index `i` is always zero. --- void checkChars(ref string s) @safe pure { dchar c; int n = -1; foreach (int i, dchar d; s) { if (!isChar(d)) { c = d; n = i; break; } } } --- This is because the foreach body is delegatized, and the internal runtime function passed it a size_t*. The fix of course is to use ptrdiff_t for the index type instead, however, the compiler should warn/error about such code. There's already a deprecation path for other kinds of arrays, char/dchar/wchar seems to have been forgotten when fixing issue 16976.

@ibuclaw created dlang/dmd pull request #9770 "Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets" fixing this issue: - Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets https://github.com/dlang/dmd/pull/9770

dlang/dmd pull request #9770 "Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets" was merged into master: - a07acfd88c92228dbc7b1ae630099722088cfc3a by Iain Buclaw: Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets https://github.com/dlang/dmd/pull/9770

dlang/dmd pull request #10009 "[dmd-cxx] Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets" was merged into dmd-cxx: - 9fcce71bd507fa57ce17d8173b6f73d320a8122b by Iain Buclaw: Fix Issue 19856 - [aApplycd2]: foreach (int) doesn't work on BigEndian targets https://github.com/dlang/dmd/pull/10009