← Back to index | Original Bugzilla link

Bug 19893 – extern(C++, "ns") should count as module scope for version declarations

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2019-05-23T05:54:27Z
Last change time
2019-05-30T07:38:30Z
Keywords
pull
Assigned to
No Owner
Creator
Manu
See also
https://issues.dlang.org/show_bug.cgi?id=13605

Comments

Comment #0 by turkeyman — 2019-05-23T05:54:27Z
version = X; version = Y; extern(C++, "std"): version = Z; version = W; 1>error : version `Z` declaration must be at module level 1>error : version `W` declaration must be at module level I feel like Z and W are still at module level...
Comment #1 by iamthewilsonator — 2019-05-25T12:50:01Z
Will fix tomorrow
Comment #2 by dlang-bot — 2019-05-26T06:19:01Z
@thewilsonator created dlang/dmd pull request #9891 "Fix issue 19893" fixing this issue: - Fix issue 19893 https://github.com/dlang/dmd/pull/9891
Comment #3 by dlang-bot — 2019-05-29T08:46:52Z
@Geod24 created dlang/dmd pull request #9912 "Fix issue 19893 - extern(C++ 'ns') should count as module scope" fixing this issue: - Fix issue 19893 - extern(C++ 'ns') should count as module scope The bug was fixed in the last commit, this just adds the test. https://github.com/dlang/dmd/pull/9912
Comment #4 by dlang-bot — 2019-05-30T07:38:30Z
dlang/dmd pull request #9912 "Fix issue 19893 - extern(C++ 'ns') should count as module scope" was merged into master: - e8800cd11167c321fcc4de65530e849774dfb273 by Geod24: Fix issue 19893 - extern(C++ 'ns') should count as module scope The bug was fixed in the last commit, this just adds the test. https://github.com/dlang/dmd/pull/9912