Bug 20014 – [REG 2.084] -transition=all, -preview=all, -revert=all is invalid

Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2019-06-30T19:20:01Z
Last change time
2020-07-09T21:25:57Z
Keywords
pull
Assigned to
No Owner
Creator
Iain Buclaw

Comments

Comment #0 by ibuclaw — 2019-06-30T19:20:01Z
Caused by PR/9206, commit 2f66b77c5869fd506800f86817187b6147647edb. Looks like wrong-code in the mixin that was refactored. src/dmd/mars.d: .... buf ~= `params.`~t.paramName~` = true;`; } - buf ~= "break;\n"; + buf ~= "return true;\n"; foreach (t; features) { ----
Comment #1 by bugzilla — 2019-12-18T10:52:40Z
Comment #2 by dlang-bot — 2020-06-30T08:21:29Z
@Geod24 updated dlang/dmd pull request #11348 "Make -{preview|revert|transition}=all work again" fixing this issue: - Fix 20014: Make -{preview|revert|transition}=all work again The code was probably changed at some point from a break to a return, but the 'all' special case was not updated. For clarity, some text was also edited: 'id' has been renamed to 'name', as 'id' has been used in the past to mean number, and it's also used this way for -version and -debug. Finally, the description for 'all' was fixed. https://github.com/dlang/dmd/pull/11348
Comment #3 by dlang-bot — 2020-07-02T10:31:40Z
dlang/dmd pull request #11348 "Make -{preview|revert|transition}=all work again" was merged into stable: - 123674c6caa1f324fc375c8df3147d945117537a by Geod24: Fix 20014: Make -{preview|revert|transition}=all work again The code was probably changed at some point from a break to a return, but the 'all' special case was not updated. For clarity, some text was also edited: 'id' has been renamed to 'name', as 'id' has been used in the past to mean number, and it's also used this way for -version and -debug. Finally, the description for 'all' was fixed. https://github.com/dlang/dmd/pull/11348
Comment #4 by dlang-bot — 2020-07-09T21:25:57Z
dlang/dmd pull request #11400 "merge stable" was merged into master: - aeddb84f15c5929e16ca915929dc2457ce3e283e by Geod24: Fix 20014: Make -{preview|revert|transition}=all work again The code was probably changed at some point from a break to a return, but the 'all' special case was not updated. For clarity, some text was also edited: 'id' has been renamed to 'name', as 'id' has been used in the past to mean number, and it's also used this way for -version and -debug. Finally, the description for 'all' was fixed. https://github.com/dlang/dmd/pull/11400