Bug 20017 – JSON (-X) compilerInfo.architectures generation depends on params.isXXX for CPU detection

These parameters will eventually become private to dmd/target.d, there is also no way for an interfacing compiler backend to add their own architectures (e.g: ARM, PowerPC, RISC-V, SystemZ, ...) Also makes an incorrect use of version(X86), as that is only evaluated on the host, not the target. if (global.params.is64bit) item("x86_64"); else version(X86) item("x86");

(In reply to Iain Buclaw from comment #0) > These parameters will eventually become private to dmd/target.d, there is > also no way for an interfacing compiler backend to add their own > architectures (e.g: ARM, PowerPC, RISC-V, SystemZ, ...) > > Also makes an incorrect use of version(X86), as that is only evaluated on > the host, not the target. > > if (global.params.is64bit) > item("x86_64"); > else > version(X86) item("x86"); To reiterate why this is bad. 1. Missing many architectures, hard coding them here would be wrong. 2. Cross compiling to x86 won't add any architectures (dmd -Xi -m32)

@wilzbach created dlang/dmd pull request #11691 "Fix Issue 20017 - JSON (-X) compilerInfo.architectures generation depends on params.isXXX for CPU detection" fixing this issue: - Fix Issue 20017 - JSON (-X) compilerInfo.architectures generation depends on params.isXXX for CPU detection https://github.com/dlang/dmd/pull/11691

dlang/dmd pull request #11691 "Fix Issue 20017 - JSON (-X) compilerInfo.architectures generation depends on params.isXXX for CPU detection" was merged into master: - 3eea345513769962b2256708b9849c8d63d695f3 by Sebastian Wilzbach: Fix Issue 20017 - JSON (-X) compilerInfo.architectures generation depends on params.isXXX for CPU detection https://github.com/dlang/dmd/pull/11691