← Back to index | Original Bugzilla link

Bug 20177 – Streamline cycle detection code due to no more duplicates

Status: NEW
Severity: enhancement
Priority: P4
Component: druntime
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2019-08-28T14:44:38Z
Last change time: 2024-12-07T13:39:35Z
Keywords: performance
Assigned to: Steven Schveighoffer
Creator: Steven Schveighoffer
See also: https://issues.dlang.org/show_bug.cgi?id=16208, https://issues.dlang.org/show_bug.cgi?id=20037

Comments

Comment #0 by schveiguy — 2019-08-28T14:44:38Z

Module cycle detection code currently deduplicates any imported modules. See issue 16208 for an explanation. However, this was recently fixed (see issue 20037). I can probably avoid allocation of the edges arrays and just use the already-existing moduleinfo data to do cycle detection to streamline the code.

Comment #1 by robert.schadek — 2024-12-07T13:39:35Z

THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dmd/issues/17388 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB