Bug 20295 – std.zip: zip64 with 0xff bytes in end of central dir record do not work
Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2019-10-10T19:19:58Z
Last change time
2019-10-18T00:00:53Z
Keywords
pull
Assigned to
No Owner
Creator
berni44
Comments
Comment #0 by bugzilla — 2019-10-10T19:19:58Z
In zip64 files, some values in the end of central dir record can be replaced by 0xff bytes. The correct values can be found elsewhere. When looking for the end of central dir record, this has to be taken into account.
This problem has probably been introduced by PR #7198.
I've got allready a fix for this, but want to add a unittest which is more difficult to create...
Comment #1 by dlang-bot — 2019-10-10T19:52:10Z
@berni44 created dlang/phobos pull request #7224 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" fixing this issue:
- Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work
https://github.com/dlang/phobos/pull/7224
Comment #2 by dlang-bot — 2019-10-16T08:42:12Z
@berni44 created dlang/phobos pull request #7229 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" fixing this issue:
- Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work
https://github.com/dlang/phobos/pull/7229
Comment #3 by dlang-bot — 2019-10-18T00:00:53Z
dlang/phobos pull request #7229 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" was merged into stable:
- 531951d8563460cd856d3047489f5a51ad31932f by Bernhard Seckinger:
Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work
https://github.com/dlang/phobos/pull/7229