Bug 20347 – Initialization of globals not checked for @safe, round 2

This was found by dkorpel while working on a DIP: https://github.com/dlang/DIPs/blob/7b109744db7fd0cfea9904354613a50e7dbdad08/DIPs/DIP1NNN-DK.md#existing-holes-in-safe The fix for issue 19646 outlaws this code: ---- @safe: const x = 42; int* y = cast(int*) &x; /* Error: cast from const(int)* to int* not allowed in safe code */ void main() { *y = 7; } ---- But the following two slight variations still pass. 1) Applying `@safe` individually: ---- @safe const x = 42; @safe int* y = cast(int*) &x; /* Should be rejected. */ @safe void main() { *y = 7; } ---- 2) Calling an @system function in the initializer: ---- @system int* f() { return cast(int*) &x; } @safe: const x = 42; int* y = f(); /* Should be rejected. */ void main() { *y = 7; } ----

Both cases seem to have been fixed. For 1) I get: test.d(2): Error: cast from `const(int)*` to `int*` not allowed in safe code For 2) I get: test.d(4): Error: `@safe` variable `y` cannot be initialized by calling `@system` function `f` Closing as WORKSFORME.

Yes, this was fixed by https://github.com/dlang/dmd/pull/14483 I forgot to link the issue