Bug 20369 – shadowed variable in foreach loop always considered "foreach variable"

void foo() { string[string] aa; string text; foreach(k, v; aa) { string text; } } onlineapp.d(7): Deprecation: variable text is shadowing variable onlineapp.foo.text. Rename the foreach variable. Note that a regular local variable is called "foreach variable".

I'm not sure I understand this bug report. Is it because the variable inside the foreach loop is referred to as a foreach variable? You would expect something along the lines of "Rename the variable in the foreach body"?

I consider "k" and "v" to be the "foreach variables", not any local variable elsewhere. I don't expect that the compiler tells me that the variable is declared inside the body of a foreach,while,if or similar.

@eoan-ermine created dlang/dmd pull request #15934 "Fix issue 20369 - shadowed variable in foreach loop always considered "foreach variable"" fixing this issue: - Fix issue 20369 - shadowed variable in foreach loop always considered "foreach variable" Remove unintuitive phrase in deprecation message https://github.com/dlang/dmd/pull/15934

dlang/dmd pull request #15934 "Fix issue 20369 - shadowed variable in foreach loop always considered "foreach variable"" was merged into master: - 8f9476e762b3de323ea86b72a621b8ee92cd6778 by Danil Sidoruk: Fix issue 20369 - shadowed variable in foreach loop always considered "foreach variable" * Remove unintuitive phrase in deprecation message * Fix deprecation message in test https://github.com/dlang/dmd/pull/15934