Bug 20748 – Deprecation for assert using shared type and checkaction=context
Status
RESOLVED
Resolution
FIXED
Severity
regression
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
All
OS
All
Creation time
2020-04-19T10:00:49Z
Last change time
2020-04-19T12:13:25Z
Keywords
pull
Assigned to
No Owner
Creator
moonlightsentinel
Comments
Comment #0 by moonlightsentinel — 2020-04-19T10:00:49Z
The following code issues a deprecation when compiled with -checkaction=context:
=======================================
void main()
{
shared ulong a = 11;
assert(a == 11);
}
=======================================
dmd -checkaction=context test.d
druntime\import\core\internal\dassert.d(86): Deprecation: argument v for format specification "%u" must be int, not shared(const(ulong))
=======================================
miniFormat did not consider shared types but this was masked by the previous rewriting of _d_assert_fail
Comment #1 by dlang-bot — 2020-04-19T10:03:10Z
@MoonlightSentinel created dlang/druntime pull request #3044 "Fix Issue 20748 - Deprecation for assert using shared type and checka…" fixing this issue:
- Fix Issue 20748 - Deprecation for assert using shared type and checkaction=context
https://github.com/dlang/druntime/pull/3044
Comment #2 by dlang-bot — 2020-04-19T12:13:25Z
dlang/druntime pull request #3044 "Fix Issue 20748 - Deprecation for assert using shared type and checka…" was merged into stable:
- 62ae7ad99b00abe0d582a781d5154579e48108c3 by MoonlightSentinel:
Fix Issue 20748 - Deprecation for assert using shared type and checkaction=context
https://github.com/dlang/druntime/pull/3044