Bug 20852 – core.sys.posix.sys.wait missing definitions on FreeBSD

Status
RESOLVED
Resolution
FIXED
Severity
major
Priority
P1
Component
druntime
Product
D
Version
D2
Platform
x86_64
OS
FreeBSD
Creation time
2020-05-21T16:40:09Z
Last change time
2020-05-24T23:32:50Z
Keywords
pull
Assigned to
No Owner
Creator
Sergei Akhmatdinov

Attachments

IDFilenameSummaryContent-TypeSize
1789reportdub build log for a vibe.d project with ldc and dmdtext/plain4541

Comments

Comment #0 by sakhmatd — 2020-05-21T16:40:09Z
Created attachment 1789 dub build log for a vibe.d project with ldc and dmd On FreeBSD 12.1, attempting to build a Vibe.d project results in errors, build logs are attached to this PR. I am using lang/ldc and the D environment downloaded from dlang.org. Adding the missing definitions should fix the issue.
Comment #1 by dlang-bot — 2020-05-23T04:32:24Z
@sakhmatd created dlang/druntime pull request #3113 "Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD" fixing this issue: - Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD https://github.com/dlang/druntime/pull/3113
Comment #2 by dlang-bot — 2020-05-23T20:21:22Z
dlang/druntime pull request #3113 "Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD" was merged into master: - b73465838a70f703cc7f55f115b3293d32edee20 by Sergei Akhmatdinov: Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD - 9ae8aa0aba4b85ba89598e591755b4789f8debe5 by Sergei Akhmatdinov: Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD https://github.com/dlang/druntime/pull/3113
Comment #3 by sakhmatd — 2020-05-24T16:09:08Z
Upon further testing with the Vibe.d suite, it appears that the entire idtype_t struct from sys/wait.h is required for some parts of eventcore to compile. After adding the missing id types, Vibe.d tests pass as intended.
Comment #4 by dlang-bot — 2020-05-24T16:15:41Z
@sakhmatd created dlang/druntime pull request #3115 "Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD" fixing this issue: - Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD Upon further testing with the Vibe.d suite, it appears that the entire idtype_t struct from sys/wait.h is required for some parts of eventcore to compile. This commit adds all of the missing id types. After adding the missing id types, Vibe.d tests pass as intended. https://github.com/dlang/druntime/pull/3115
Comment #5 by dlang-bot — 2020-05-24T23:32:50Z
dlang/druntime pull request #3115 "Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD" was merged into master: - 4b70715194b6cbed8d77dda59df5faf5dfbda49f by Sergei Akhmatdinov: Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD Upon further testing with the Vibe.d suite, it appears that the entire idtype_t struct from sys/wait.h is required for some parts of eventcore to compile. This commit adds all of the missing id types. After adding the missing id types, Vibe.d tests pass as intended. https://github.com/dlang/druntime/pull/3115