Bug 20889 – Support construction of std.bigint.BigInt from a sign and a byte-array magnitude

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2020-06-01T05:47:00Z
Last change time
2020-06-20T01:08:21Z
Keywords
pull
Assigned to
No Owner
Creator
Nathan S.
See also
https://issues.dlang.org/show_bug.cgi?id=13804

Comments

Comment #0 by n8sh.secondary — 2020-06-01T05:47:00Z
Support construction of std.bigint.BigInt from a sign and a byte-array magnitude. Having it in the library would avoid the necessity of workarounds seen in the wild like https://github.com/shove70/crypto/blob/4052a5ef41c604b274ffff8bf6011180cd3a474d/src/crypto/bigint.d#L91-L112 See related https://issues.dlang.org/show_bug.cgi?id=13804
Comment #1 by dlang-bot — 2020-06-01T05:51:34Z
@n8sh created dlang/phobos pull request #7511 "Support construction of std.bigint.BigInt from a sign and a byte-array magnitude" fixing this issue: - Fix Issue 20889 - Support construction of std.bigint.BigInt from a sign and a byte-array magnitude For consistency with other std.bigint functions allows arbitrary ranges. https://github.com/dlang/phobos/pull/7511
Comment #2 by dlang-bot — 2020-06-20T01:08:21Z
dlang/phobos pull request #7511 "Support construction of std.bigint.BigInt from a sign and a byte-array magnitude" was merged into master: - a0f4b65db87a5b349bd175371607a082a5858c37 by Nathan Sashihara: Fix Issue 20889 - Support construction of std.bigint.BigInt from a sign and a byte-array magnitude For consistency with other std.bigint functions allows arbitrary ranges. https://github.com/dlang/phobos/pull/7511