← Back to index | Original Bugzilla link

Bug 21006 – core.internal.hash.bytesHash: in 64-bit builds use a 64-bit-oriented algorithm

Status
NEW
Severity
enhancement
Priority
P4
Component
druntime
Product
D
Version
D2
Platform
x86_64
OS
All
Creation time
2020-07-02T00:03:33Z
Last change time
2024-12-07T13:40:25Z
Keywords
pull
Assigned to
No Owner
Creator
Nathan S.
Moved to GitHub: dmd#17407 →

Comments

Comment #0 by n8sh.secondary — 2020-07-02T00:03:33Z
Currently all builds use 32-bit MurmurHash3 for core.internal.hash.bytesHash. On 64-bit builds this means the high 32 bits of the initial seed are discarded (which is relevant for chained uses of hashOf) and only the low 32 bits of the output are populated. In addition to fixing those problems speed improvement is also possible.
Comment #1 by dlang-bot — 2020-07-02T00:46:04Z
@n8sh created dlang/druntime pull request #3148 "core.internal.hash.bytesHash: in 64-bit builds use a 64-bit-oriented algorithm" fixing this issue: - Fix Issue 21006 - core.internal.hash.bytesHash: in 64-bit builds use a 64-bit-oriented algorithm https://github.com/dlang/druntime/pull/3148
Comment #2 by robert.schadek — 2024-12-07T13:40:25Z
THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dmd/issues/17407 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB