← Back to index | Original Bugzilla link

Bug 21103 – isDynamicArray instantiates unecessary templates

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2020-08-02T18:14:56Z
Last change time: 2021-01-22T17:27:32Z
Keywords: pull
Assigned to: No Owner
Creator: moonlightsentinel

Comments

Comment #0 by moonlightsentinel — 2020-08-02T18:14:56Z

See https://github.com/dlang/dmd/pull/9014#issuecomment-667704187 for an extensive overview. TL:DR. isDynamicArray should use an is-Expression instead of additional templates.

Comment #1 by dlang-bot — 2020-08-02T18:16:03Z

@MoonlightSentinel created dlang/phobos pull request #7574 "Fix Issue 21103 - isDynamicArray instantiates unecessary templates" fixing this issue: - Fix Issue 21103 - isDynamicArray instantiates unecessary templates https://github.com/dlang/phobos/pull/7574

Comment #2 by dlang-bot — 2021-01-22T17:27:32Z

dlang/phobos pull request #7574 "Fix Issue 21103 - isDynamicArray instantiates unecessary templates" was merged into master: - 7bea4c78b90c4ca182298ebc758a41edc7227315 by MoonlightSentinel: Fix Issue 21103 - isDynamicArray instantiates unecessary templates Use an `is(...)` expression to do the actual check but include a workaround to reatin the old (buggy) behaviour regarding enums (for now). https://github.com/dlang/phobos/pull/7574