← Back to index | Original Bugzilla link

Bug 21707 – std.base64: Faulty input creates range error instead of Base64Exception

Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2021-03-13T14:29:02Z
Last change time
2021-03-16T23:05:18Z
Keywords
pull
Assigned to
No Owner
Creator
Berni44

Comments

Comment #0 by bugzilla — 2021-03-13T14:29:02Z
This fails: unittest { import std.exception : assertThrown; char[][] t = [[ 'Z', 'g', '=' ]]; assertThrown!Base64Exception(Base64.decoder(t)); }
Comment #1 by dlang-bot — 2021-03-13T14:49:26Z
@berni44 created dlang/phobos pull request #7857 "Fix Issue 21707 - std.base64: Faulty input creates range error…" fixing this issue: - Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception https://github.com/dlang/phobos/pull/7857
Comment #2 by dlang-bot — 2021-03-13T16:42:29Z
dlang/phobos pull request #7857 "Fix Issue 21707 - std.base64: Faulty input creates range error…" was merged into master: - 4f61975185f990d840ea2695b52b3153d03d76fd by berni44: Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception https://github.com/dlang/phobos/pull/7857
Comment #3 by dlang-bot — 2021-03-14T10:25:06Z
dlang/phobos pull request #7861 "Revert "Fix Issue 21707 - std.base64: Faulty input creates range erro…" was merged into master: - 5bfa8d7e055667e3eaf1bbc934331ca3336839ce by berni44: Revert "Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception" This reverts commit cf41baba2123e1c4680baf06016b8a93bbaf57ce. https://github.com/dlang/phobos/pull/7861
Comment #4 by bugzilla — 2021-03-14T10:43:59Z
I had to revert my fix from yesterday, because it introduced a regression.
Comment #5 by dlang-bot — 2021-03-16T17:21:38Z
@berni44 created dlang/phobos pull request #7871 "Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception" fixing this issue: - Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception https://github.com/dlang/phobos/pull/7871
Comment #6 by dlang-bot — 2021-03-16T23:05:18Z
dlang/phobos pull request #7871 "Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception" was merged into master: - d4c58aabe5e2e7ab95c944e73612ec5d9fc9e4e7 by berni44: Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception https://github.com/dlang/phobos/pull/7871