← Back to index | Original Bugzilla link

Bug 21810 – Check for sortedness in `merge` must not use `==`

Status: RESOLVED
Resolution: FIXED
Severity: minor
Priority: P1
Component: phobos
Product: D
Version: D2
Platform: All
OS: All
Creation time: 2021-04-08T09:39:49Z
Last change time: 2021-04-14T15:58:22Z
Keywords: pull
Assigned to: No Owner
Creator: arne.ludwig

Comments

Comment #0 by arne.ludwig — 2021-04-08T09:39:49Z

Checking sortedness according to a given predicate must not use `==` operator because it may not be in accordance with the predicate. In `std.algorithm.sorting.merge` this is happening which produces an unjustified error in some cases.

Comment #1 by dlang-bot — 2021-04-08T14:25:33Z

@a-ludi updated dlang/phobos pull request #7928 "Check for sortedness must not use `==`" fixing this issue: - Fix issue 21810: Check for sortedness must not use `==` https://github.com/dlang/phobos/pull/7928

Comment #2 by dlang-bot — 2021-04-14T15:58:22Z

dlang/phobos pull request #7928 "Check for sortedness must not use `==`" was merged into master: - b13306c667cf818aa8ed624777fbfbfede5d0c1f by Arne: Fix issue 21810: Check for sortedness must not use `==` https://github.com/dlang/phobos/pull/7928