Bug 21932 – importC: enum 'ENUM' conflicts with enum 'ENUM'

The parser allows implicit typedefs, which is not valid C. --- struct STRUCT { void *opaque; }; STRUCT mystruct; // Should error. --- Instead, it errors on the correct way to declare variables of type 'struct'. --- struct STRUCT { void *opaque; }; struct STRUCT mystruct; // Error --- Same goes for enums --- enum ENUM { ENUM_a }; enum ENUM myenum; // Error ---

(In reply to Iain Buclaw from comment #0) > The parser allows implicit typedefs, which is not valid C. > --- > struct STRUCT { void *opaque; }; > STRUCT mystruct; // Should error. > --- This is probably not so easily solvable though, as the error should happen in the semantic (but the semantic follows D rules!) The immediate issue should focus on getting `struct S s;` working.

This is actually how C++ works, and it compiles C fine. It is not rigorous C, to be sure, but I think we're all right with it.

(In reply to Walter Bright from comment #2) > This is actually how C++ works, and it compiles C fine. > > It is not rigorous C, to be sure, but I think we're all right with it. Yeah, I'll removed the accepts-invalid tag. In principle there's nothing wrong will accepting more than what a typical C compiler would so long as it can be justified.

The struct test case has been fixed with the introduction of TypeTag. The enum test case still fails, however. --- enum ENUM { ENUM_a }; enum ENUM myenum; // Error

@ibuclaw created dlang/dmd pull request #12723 "fix Issue 21932, 22060 - importC: Multiple forward declarations result in error struct conflicts with struct" fixing this issue: - fix Issue 21932 - importC: enum 'ENUM' conflicts with enum 'ENUM' https://github.com/dlang/dmd/pull/12723

@WalterBright created dlang/dmd pull request #12787 "fix Issue 21932 ImportC: enum ENUM conflicst with enum ENUM" fixing this issue: - fix Issue 21932 ImportC: enum ENUM conflicst with enum ENUM https://github.com/dlang/dmd/pull/12787

Fix was committed but issue did not get auto-closed.