Bug 22070 – importC: Error: string/array literal is not an lvalue

It is an lvalue in C """ 6.5.1-4: A string literal is a primary expression. It is an lvalue with type as detailed in 6.4.5. """ Reduced test --- char(*var)[4] = &"123";

Interestingly, dmc rejects it, too, with cannot take the address of a string.

@WalterBright created dlang/dmd pull request #12888 "Issue 22070 - importC: Error: string literal is not an lvalue" mentioning this issue: - Issue 22070 - importC: Error: string literal is not an lvalue https://github.com/dlang/dmd/pull/12888

@WalterBright created dlang/dmd pull request #12889 "fix Issue 22070 - importC: Error: string literal is not an lvalue" fixing this issue: - fix Issue 22070 - importC: Error: string literal is not an lvalue https://github.com/dlang/dmd/pull/12889

dlang/dmd pull request #12889 "fix Issue 22070 - importC: Error: string literal is not an lvalue" was merged into master: - 9a377cbe666a669eee67ebc9d26796249cf4e488 by Walter Bright: fix Issue 22070 - importC: Error: string literal is not an lvalue https://github.com/dlang/dmd/pull/12889

This also applies to array literals, per 6.5.2.5-4: > In either case [array or object], the result is an lvalue. ``` short(*v1)[2] = &(short[]){1, 2}; ``` Object literals act as lvalues as expected. Additionally, the following invalid code is now accepted: ``` char(**s1)[3] = &(&"aa"); char(***s2)[3] = &(&(&"aa")); // and so on ```

@Yoplitein created dlang/dmd pull request #14028 "Expand fix for issue 22070 to also allow array literals as lvalues" mentioning this issue: - Expand fix for issue 22070 to also allow array literals as lvalues Check for and restrict nested address-of expressions on literals, such as `&(&"")` https://github.com/dlang/dmd/pull/14028

dlang/dmd pull request #14028 "Expand fix for issue 22070 to also allow array literals as lvalues" was merged into master: - 95f218d081b0695836f901b62f0b16bb68107449 by Steven Dwy: Expand fix for issue 22070 to also allow array literals as lvalues Check for and restrict nested address-of expressions on literals, such as `&(&"")` https://github.com/dlang/dmd/pull/14028

@WalterBright updated dlang/dmd pull request #14049 "fix Issue 23057 - importC: dmd segfault on invalid syntax" mentioning this issue: - Expand fix for issue 22070 to also allow array literals as lvalues Check for and restrict nested address-of expressions on literals, such as `&(&"")` https://github.com/dlang/dmd/pull/14049

@ljmf00 updated dlang/dmd pull request #14058 "fix(backend): define XMM load/store codegen for short type variants" mentioning this issue: - Expand fix for issue 22070 to also allow array literals as lvalues Check for and restrict nested address-of expressions on literals, such as `&(&"")` https://github.com/dlang/dmd/pull/14058

@WalterBright updated dlang/dmd pull request #14044 "fix Issue 23058 - importC: cannot take address inside multi-dimension…" mentioning this issue: - Expand fix for issue 22070 to also allow array literals as lvalues Check for and restrict nested address-of expressions on literals, such as `&(&"")` https://github.com/dlang/dmd/pull/14044

(In reply to Steven Dwy from comment #5) > This also applies to array literals, per 6.5.2.5-4: > > In either case [array or object], the result is an lvalue. Please do not reopen fixed bugs to report new bugs. If you find another bug, open another bugzilla issue.

As far as I can tell, this all works correctly with master. If other issues are found, please do not reopen this. Open a new issue.