Bug 22315 – ImportC: #pragma pack is not implemented

I believe Walter has said that he doesn’t intend to support #pragma pack, but I have discovered some macOS system headers that use the feature. At least, fcntl.h and sys/event.h use the feature in defining some structures. An example from event.h: #pragma pack(4) struct kevent { uintptr_t ident; /* identifier for this event */ int16_t filter; /* filter for event */ uint16_t flags; /* general flags */ uint32_t fflags; /* filter-specific flags */ intptr_t data; /* filter-specific data */ void *udata; /* opaque user data identifier */ }; #pragma pack() (I have no idea why pragma pack is even used here, the structure has no padding). I haven’t studied the headers closely enough to see if ignoring it matters or not.

It would have padding if uintptr_t is 64 bits.

https://gcc.gnu.org/onlinedocs/gcc-4.4.4/gcc/Structure_002dPacking-Pragmas.html https://docs.microsoft.com/en-us/cpp/preprocessor/pack?view=msvc-160

https://gcc.gnu.org/onlinedocs/gcc-3.3/gcc/Type-Attributes.html for: __attribute__ ((aligned)) __attribute__ ((packed))

@WalterBright created dlang/dmd pull request #13166 "fix Issue 22315 - ImportC: #pragma pack is not implemented" fixing this issue: - fix Issue 22315 - ImportC: #pragma pack is not implemented https://github.com/dlang/dmd/pull/13166

dlang/dmd pull request #13166 "fix Issue 22315 - ImportC: #pragma pack is not implemented" was merged into stable: - fc97a3c00146f8ee1a6ae6d89f64b9bbcd80ad34 by Walter Bright: fix Issue 22315 - ImportC: #pragma pack is not implemented https://github.com/dlang/dmd/pull/13166

dlang/dmd pull request #13209 "Merge stable into master" was merged into master: - 3131d4789f3af6fab2040cfcc5897c0113e41335 by Walter Bright: fix Issue 22315 - ImportC: #pragma pack is not implemented (#13166) https://github.com/dlang/dmd/pull/13209