← Back to index | Original Bugzilla link

Bug 22328 – Specific D types are used instead of Windows type aliases

Status: RESOLVED
Resolution: FIXED
Severity: normal
Priority: P1
Component: druntime
Product: D
Version: D2
Platform: All
OS: Windows
Creation time: 2021-09-22T07:04:38Z
Last change time: 2021-09-24T12:53:21Z
Keywords: pull
Assigned to: No Owner
Creator: Max Samukha

Comments

Comment #0 by maxsamukha — 2021-09-22T07:04:38Z

Using D types directly leads to subtle bugs like BOOL being translated to bool or LONG to long (both should be int). For example, core.sys.windows.dll.SimpleDllMain.DllMain has bool instead of BOOL as the return type (https://github.com/dlang/druntime/pull/3571)

Comment #1 by dlang-bot — 2021-09-22T14:51:39Z

@maxsamukha updated dlang/druntime pull request #3571 "Fix issue 22328: Specific D types are used instead of Windows type aliases" fixing this issue: - Fix issue 22328: Specific D types are used instead of Windows type aliases https://github.com/dlang/druntime/pull/3571

Comment #2 by dlang-bot — 2021-09-24T12:53:21Z

dlang/druntime pull request #3571 "Fix issue 22328: Specific D types are used instead of Windows type aliases" was merged into master: - e0b9c6d714e3f0e52b2d16243de4b3ef6c78e7f2 by Max Samukha: Fix issue 22328: Specific D types are used instead of Windows type aliases https://github.com/dlang/druntime/pull/3571