Bug 22353 – Header generation is producing trailing whitespace on attribute declarations

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
All
OS
All
Creation time
2021-10-03T19:21:49Z
Last change time
2021-10-05T12:31:12Z
Keywords
pull
Assigned to
No Owner
Creator
Luís Ferreira

Comments

Comment #0 by contact — 2021-10-03T19:21:49Z
DMD should generate clean headers without trailing whitespace, when possible. This case it generates a trailing whitespace for AttribDeclaration when an storage class is provided. ``` @safe { void foo() {} void bar() {} } ``` This will produce a trailing whitespace on the first line corresponding to the header generated
Comment #1 by dlang-bot — 2021-10-03T19:23:30Z
@ljmf00 created dlang/dmd pull request #13121 "hdrgen: remove trailing whitespace on attribute declarations" fixing this issue: - hdrgen: remove trailing whitespace on attribute declarations Fixes Issue 22353. Signed-off-by: Luís Ferreira <[email protected]> https://github.com/dlang/dmd/pull/13121
Comment #2 by dlang-bot — 2021-10-05T12:31:12Z
dlang/dmd pull request #13121 "hdrgen: remove trailing whitespace on attribute declarations" was merged into master: - 2e7c7eea9f2d85e9806a9af3afb6a53cd798a02b by Luís Ferreira: hdrgen: remove trailing whitespace on attribute declarations Fixes Issue 22353. Signed-off-by: Luís Ferreira <[email protected]> https://github.com/dlang/dmd/pull/13121