Bug 22355 – LLD fallback for mscoff is broken in the presence of some old VS versions

Status
RESOLVED
Resolution
FIXED
Severity
enhancement
Priority
P1
Component
dmd
Product
D
Version
D2
Platform
x86
OS
Windows
Creation time
2021-10-04T09:24:36Z
Last change time
2021-10-05T06:39:14Z
Keywords
pull
Assigned to
No Owner
Creator
Nicholas Wilson

Comments

Comment #0 by iamthewilsonator — 2021-10-04T09:24:36Z
https://github.com/dlang/dmd/pull/13110#issuecomment-931657202 reporter is using VS2010. We should probably not support these old VS versions since these are no longer supported by microsoft, but the fallback path should not break just because someone has an old VS version.
Comment #1 by dlang-bot — 2021-10-04T09:35:08Z
@thewilsonator created dlang/dmd pull request #13125 "Fix issue 22355: LLD fallback for mscoff is broken in the presence of…" fixing this issue: - Fix issue 22355: LLD fallback for mscoff is broken in the presence of some old VS versions https://github.com/dlang/dmd/pull/13125
Comment #2 by dlang-bot — 2021-10-05T06:39:14Z
dlang/dmd pull request #13125 "Fix issue 22355: LLD fallback for mscoff is broken in the presence of…" was merged into master: - 9500185c39aafaa4d4ee56c64bd41b11d91d8c66 by Nicholas Wilson: Fix issue 22355: LLD fallback for mscoff is broken in the presence of some old VS versions https://github.com/dlang/dmd/pull/13125