Bug 22503 – Invalid changelog entry for isValidCodePoint
Status
RESOLVED
Resolution
FIXED
Severity
normal
Priority
P1
Component
phobos
Product
D
Version
D2
Platform
All
OS
All
Creation time
2021-11-11T14:29:12Z
Last change time
2022-04-13T23:39:29Z
Keywords
pull
Assigned to
No Owner
Creator
kdevel
Comments
Comment #0 by kdevel — 2021-11-11T14:29:12Z
According to
https://dlang.org/changelog/2.098.0.html#add_isValidCharacter
there is a new function in std.utf named isValidCharacter.
$ dmd --version
DMD64 D Compiler v2.098.0
Copyright (C) 1999-2021 by The D Language Foundation, All Rights Reserved written by Walter Bright
$ cat v.d
import std.utf;
void main ()
{
assert(!isValidCharacter(cast(char) 0x80));
}
$ dmd v
v.d(4): Error: undefined identifier `isValidCharacter`
Comment #1 by moonlightsentinel — 2021-11-11T17:22:14Z
The function was renamed during the review of the PR but that change was not reflected in the changelog. The correct name is `isValidCodePoint`.
https://github.com/dlang/phobos/pull/8043
Comment #2 by kdevel — 2021-11-11T17:49:16Z
(In reply to moonlightsentinel from comment #1)
> [...] The correct name is `isValidCodePoint`.
validtest.d(7): Error: undefined identifier `isValidCodePoint`, did you mean template `isValidCodepoint [...]
Comment #3 by moonlightsentinel — 2021-11-11T21:40:40Z
(In reply to kdevel from comment #2)
> validtest.d(7): Error: undefined identifier `isValidCodePoint`, did you mean
> template `isValidCodepoint [...]
Indeed, that was a typo.
Comment #4 by dlang-bot — 2022-04-13T13:20:42Z
@dkorpel created dlang/dlang.org pull request #3278 "Fix issue 22503 - Invalid changelog entry for isValidCodePoint" fixing this issue:
- Fix issue 22503 - Invalid changelog entry for isValidCodePoint
https://github.com/dlang/dlang.org/pull/3278
Comment #5 by dlang-bot — 2022-04-13T23:39:29Z
dlang/dlang.org pull request #3278 "Fix issue 22503 - Invalid changelog entry for isValidCodePoint" was merged into master:
- b434099e306ba94b5b97506e1bc185501bc7e7a6 by Dennis Korpel:
Fix issue 22503 - Invalid changelog entry for isValidCodePoint
https://github.com/dlang/dlang.org/pull/3278