Bug 22721 – importC: some gnu builtins are rejected

Trying to compile CoreFoundation.h on macOS has led me to encounter the following builtins, which are documented here: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html __builtin_bswap32 __builtin_bswap64 __builtin_constant_p __builtin_expect __builtin_assume The last 3 are just optimization hints.

This will have to wait for: https://github.com/dlang/druntime/pull/3702 to get merged.

dlang/druntime pull request #3720 "fix Issue 22721 - importC: some gnu builtins are rejected" was merged into master: - 77101360cbf65040dd7cbb151027c7995c5bc6a1 by Walter Bright: fix Issue 22721 - importC: some gnu builtins are rejected https://github.com/dlang/druntime/pull/3720

slight issue with the fix: "__builtin_assume_aligned" in the linked GNU docs is different from the "__builtin_assume" mentioned in the issue, the actual one is documented here: https://releases.llvm.org/13.0.0/tools/clang/docs/LanguageExtensions.html#builtin-assume its D implementation would be void __builtin_assume()(lazy bool) { return; } the assume builtin added in the PR has the signature of __builtin_assume_aligned from the docs but is named __builtin_assume, it should be renamed to add _aligned

also, __builtin_expect in the PR is using the D long type but should probably use c_long

(In reply to duser from comment #3) > slight issue with the fix: > > "__builtin_assume_aligned" in the linked GNU docs is different from the > "__builtin_assume" mentioned in the issue, the actual one is documented here: > > https://releases.llvm.org/13.0.0/tools/clang/docs/LanguageExtensions. > html#builtin-assume > > its D implementation would be > > void __builtin_assume()(lazy bool) { return; } > > the assume builtin added in the PR has the signature of > __builtin_assume_aligned > from the docs but is named __builtin_assume, it should be renamed to add > _aligned __builtin_assume is a clang extension, which I don’t think GCC has. https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Builtins.def#L1550. It is present in at least <dispatch/dispatch.h> on macOS.

I fixed this with a macro, as there's no way to tell dmd to not evaluate `arg`. https://github.com/dlang/druntime/pull/3730

(In reply to Walter Bright from comment #6) > I fixed this with a macro, as there's no way to tell dmd to not evaluate > `arg`. I found a way - make the parameter lazy.

@WalterBright created dlang/druntime pull request #3734 "fix Issue 22721 - importC: some gnu builtins are rejected" fixing this issue: - fix Issue 22721 - importC: some gnu builtins are rejected https://github.com/dlang/druntime/pull/3734

dlang/druntime pull request #3734 "fix Issue 22721 - importC: some gnu and clang builtins are rejected" was merged into master: - d31ad8004c1d8674979a8103d218bd9cd2dc3c22 by Walter Bright: fix Issue 22721 - importC: some gnu and clang builtins are rejected https://github.com/dlang/druntime/pull/3734

dlang/dmd pull request #14281 "[project] Merge druntime into the dmd repository" was merged into master: - f9a44c3a3cb47c5604db1a34b821a3b0e679b8b8 by Walter Bright: fix Issue 22721 - importC: some gnu builtins are rejected https://github.com/dlang/dmd/pull/14281